Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker,auth): Add Docker, Compose, Auth, Parameter envs #6

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

sammcj
Copy link
Contributor

@sammcj sammcj commented Sep 15, 2024

Neat project!

I wanted to make some changes and thought I'd submit them to you in a PR, totally understand if you're not interested in them though - if that's the case feel free to close the PR.

  • Feat: Add Dockerfile for container builds.
  • Feat: Add Docker Compose example.
  • Feat: Add optional authentication to the optillm proxy.
  • Feat: Add the option of configuring optillm via environment variables.
  • Feat: Add basic /health endpoint.
  • Docs: Add documentation for running with Docker.
  • Docs: Add documentation for args.
  • Fix: Clean up mix of - and _ in args, handle old _ args for backwards compatibility.
  • Fix: Minor linting in readme.
  • Chore: Move arg parsing out of main to it's own class.

@codelion codelion self-requested a review September 15, 2024 01:33
@codelion
Copy link
Owner

Thanks for the PR I was planning on adding docker support as well. I have done a quick review and I am going to merge it now.

@codelion codelion merged commit e5c7cd0 into codelion:main Sep 15, 2024
Copy link
Owner

@codelion codelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants